This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR5692


On Mon, Feb 04, 2008 at 11:47:37AM +0000, Nick Clifton wrote:
> Hi Alan,
>
>> I believe this is a better fix for PR5692.  It isn't valid to use
>> get_elf_backend_data on non-ELF input BFDs, and testing for NULL won't
>> catch other targets that happen to use their backend_data field.
>
> Fair enough.  Although I see nothing wrong with checking for a NULL return 
> from get_elf_backend_data(), just in case a future programming bug creates 
> an ELF target with a null backend data structure.
>

We don't check NULL get_elf_backend_data for most, if not all, of
places where it is used. Whoever implmenets such a target should
get a core dump immediately. It will help fix the problem.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]