Re: [patch bfd]: Add further support for x86_64 mingw

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Feb 04, 2008 at 04:50:54PM +0100, Kai Tietz wrote:
> "H.J. Lu" wrote on 04.02.2008 16:38:03:
> 
> > On Mon, Feb 04, 2008 at 04:10:05PM +0100, Kai Tietz wrote:
> > > Hi H.J.,
> > > 
> > > > On Mon, Feb 04, 2008 at 12:02:43PM +0100, Kai Tietz wrote:
> > > > > Hi H.J.,
> > > > > 
> > > > > I patched bfd/warning.m4. Could you review it. It should diable 
> the 
> > > > > -Werror option for host mingw.
> > > > > You need to regenerate the configure scripts, because I have 
> currently 
> > > no 
> > > > > ability to re-generate them.
> > > > > 
> > > > > ChangeLog
> > > > > 
> > > > > 2008-02-04      Kai Tietz  <kai.tietz@onevision.com>
> > > > > 
> > > > >         * bfd/warning.m4: Disable by default -Werror for mingw.
> > > > >         * bfd/configure: Regenerate.
> > > > >         * gas/configure: Regenerate.
> > > > >         * binutils/configure: Regenerate.
> > > > >         * ld/configure: Regenerate.
> > > > > 
> > > > 
> > > > Please mention PR 5715 in your ChangeLog.
> > > 
> > > 2008-02-04      Kai Tietz  <kai.tietz@onevision.com>
> > > 
> > >         PR/5715
> > >         * bfd/warning.m4: Disable by default -Werror for mingw.
> >                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >              It is wrong.
> > > 
> > > +# Disable -Werror by default when using gcc and mingw
> >            ^^^^^^^^^^^^^
> >       It is wrong.
> > > +case "${host}" in
> > > +  *-*-mingw32*)
> > > +    if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
> > > +      GCC_WARN_CFLAGS="$GCC_WARN_CFLAGS -Wno-format"
> > > +    fi
> > > +    ;;
> > > +  *) ;;
> > > +esac
> > > +
> > 
> > Do you want to use -Wno-format on 64bit mingw? I thought 64bit mingw
> > was OK.  Otherwise, you will see the same error on 64bit mingw.
> 
> Yes, because this feature is available until gcc 4.4 (AFAICS). If you 
> don't apply the patch file for gcc 4.3, you will have the same results as 
> for any mingw target. The patch to gcc affects all mingw targets.
> 

Thanks.  Please update your patch with "-Wno-format" instead of
"Disable -Werror by default".


H.J.