Re: [Fwd: RFA:] Print mips-specific dynamic tags with objdump -p

[Nick Clifton <nickc at redhat dot com>]

Hi Catherine,

> Okay to install?

Yes, but with one change....

This part of the patch:

> Index: elf.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf.c,v
> retrieving revision 1.435
> diff -p -r1.435 elf.c
> *** elf.c    17 Feb 2008 23:45:23 -0000    1.435
> --- elf.c    26 Feb 2008 00:27:33 -0000
> *************** _bfd_elf_print_private_bfd_data (bfd *ab
> *** 1281,1287 ****
>           case DT_GNU_HASH: name = "GNU_HASH"; break;
>           }
>
> !       fprintf (f, "  %-11s ", name);
>         if (! stringp)
>           fprintf (f, "0x%lx", (unsigned long) dyn.d_un.d_val);
>         else
> --- 1288,1294 ----
>           case DT_GNU_HASH: name = "GNU_HASH"; break;
>           }
>
> !       fprintf (f, "  %-20s ", name);
>         if (! stringp)
>           fprintf (f, "0x%lx", (unsigned long) dyn.d_un.d_val);
>         else

Breaks the test in ld/testsuite/ld-cris/libdso-10.d.  (Try running the 
linker testsuite for a cris-elf toolchain to see this).  Please can you 
update the expected objdump output in that file so that it will accept 
an arbitrary number of spaces between the name of the dynamic tag and 
its value.

Cheers
  Nick