This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] bug 5543: do not allow register symbols to be global

From: Nick Clifton <nickc at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Denys Vlasenko <vda dot linux at googlemail dot com>, Binutils <binutils at sourceware dot org>
Date: Mon, 03 Mar 2008 14:58:49 +0000
Subject: Re: [PATCH] bug 5543: do not allow register symbols to be global
References: <200802211239.27444.vda.linux@googlemail.com> <20080221143916.GA8674@lucon.org> <47C833A3.1050003@redhat.com> <20080302172818.GA15412@lucon.org>

Hi H.J.

gas/
2008-03-02  Denys Vlasenko <vda.linux@googlemail.com>
	    H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/5543
	* read.c (pseudo_set): Don't allow global register symbol.

	* symbols.c (S_SET_EXTERNAL): Don't allow register symbol
	global.

2008-03-02 H.J. Lu <hongjiu.lu@intel.com>

	PR gas/5543
	* write.c (write_object_file): Don't allow symbols which were
	equated to register.  Stop if there is an error.

gas/testsuite/
2008-03-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR gas/5543
	* gas/i386/i386.exp: Run inval-equ-1 and inval-equ-2.

	* gas/i386/inval-equ-1.l: New.
	* gas/i386/inval-equ-1.s: Likewise.
	* gas/i386/inval-equ-2.l: Likewise.
	* gas/i386/inval-equ-2.s: Likewise.

Approved - please apply.

Note: I think that the error message in pseudo_set() is a little
unclear.  How about this instead ?

cannot equate global symbol '%s' with register name


Cheers
  Nick

Follow-Ups:
- Re: [PATCH] bug 5543: do not allow register symbols to be global
  - From: H.J. Lu

References:
- Re: [PATCH] bug 5543: do not allow register symbols to be global
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]