This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: FIx gas macro test: test1.s


Hi Guys,

  I am applying the patch below to fix a problem with the test1.s file
  in the gas macro tests.  It was a latent bug which was only exposed
  by the recent fix to catch attempts to turn strings that match
  register names into global symbols.  The test used the strings s1
  and s2 which match register names for the DLX port, so I am going to
  apply a simple fix to choose names which a very unlikely to ever
  match the names of any register.

Cheers
  Nick

gas/testsuite/ChangeLog
2008-03-18  Nick Clifton  <nickc@redhat.com>

	* gas/macros/test1.s: Rename symbols to avoid conflicts with
	possible register names.
	* gas/macros/test1.d: Update expected disassembly.

Index: gas/testsuite/gas/macros/test1.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/macros/test1.s,v
retrieving revision 1.1.1.1
diff -c -3 -p -r1.1.1.1 test1.s
*** gas/testsuite/gas/macros/test1.s	3 May 1999 07:28:51 -0000	1.1.1.1
--- gas/testsuite/gas/macros/test1.s	18 Mar 2008 16:38:27 -0000
***************
*** 3,7 ****
  	\arg1 = \arg2
  	.endm
  
! 	m s1,1
! 	m s2,2
--- 3,7 ----
  	\arg1 = \arg2
  	.endm
  
! 	m s_not_a_reg_1,1
! 	m s_not_a_reg_2,2
Index: gas/testsuite/gas/macros/test1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/macros/test1.d,v
retrieving revision 1.1.1.1
diff -c -3 -p -r1.1.1.1 test1.d
*** gas/testsuite/gas/macros/test1.d	3 May 1999 07:28:51 -0000	1.1.1.1
--- gas/testsuite/gas/macros/test1.d	18 Mar 2008 16:38:37 -0000
***************
*** 1,5 ****
  #nm: --extern-only
  #name: macro test 1
  
! 0+01 A s1
! 0+02 A s2
--- 1,5 ----
  #nm: --extern-only
  #name: macro test 1
  
! 0+01 A s_not_a_reg_1
! 0+02 A s_not_a_reg_2


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]