Re: Binutils head broken?

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Thu, Mar 20, 2008 at 10:57:43PM -0400, NightStrike wrote:
> On 3/20/08, NightStrike <nightstrike@gmail.com> wrote:
> > I can't compile binutils HEAD anymore when:
> >
> > build=host=target=x86_64-pc-linux
> > build=host=x86_64-pc-linux  && target=x86_64-pc-mingw32
> >
> >
> > I get this:
> >
> > ../../src/binutils/readelf.c: In function 'process_mips_specific':
> > ../../src/binutils/readelf.c:9581: warning: field width should have
> > type 'int', but argument 2 has type 'size_t'
> > ../../src/binutils/readelf.c:9581: warning: field width should have
> > type 'int', but argument 5 has type 'size_t'
> > ../../src/binutils/readelf.c:9598: warning: field width should have
> > type 'int', but argument 2 has type 'size_t'
> > ../../src/binutils/readelf.c:9598: warning: field width should have
> > type 'int', but argument 5 has type 'size_t'
> > ../../src/binutils/readelf.c:9615: warning: field width should have
> > type 'int', but argument 2 has type 'size_t'
> > ../../src/binutils/readelf.c:9615: warning: field width should have
> > type 'int', but argument 5 has type 'size_t'
> > ../../src/binutils/readelf.c:9615: warning: field width should have
> > type 'int', but argument 7 has type 'size_t'
> >
> 

All 64bit hosts will fail. I am checking in this patch.


H.J.
--- binutils/readelf.c.foo	2008-03-20 20:18:03.000000000 -0700
+++ binutils/readelf.c	2008-03-20 20:23:18.000000000 -0700
@@ -9565,8 +9565,9 @@ process_mips_specific (FILE *file)
   if (pltgot != 0 && local_gotno != 0)
     {
       bfd_vma entry, local_end, global_end;
-      size_t addr_size, i, offset;
+      size_t i, offset;
       unsigned char *data;
+      int addr_size;
 
       entry = pltgot;
       addr_size = (is_32bit_elf ? 4 : 8);