This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOLD PATCH]: Support for some more options.


From: Ian Lance Taylor <iant@google.com>
Date: Wed, 16 Apr 2008 08:44:59 -0700

> David Miller <davem@davemloft.net> writes:
> 
> > +  odyn->add_constant(elfcpp::DT_FLAGS_1, flags);
> 
> I think we should only emit DT_FLAGS_1 when flags != 0.

Ok, but I was merely mirroring the logic you were using for DT_FLAGS,
in that we might want to allow tools to edit the DT_FLAGS_1 value in
the binary after it has been linked.

> We can get better help messages here by copying the ones in
> ld/emultempl/elf32.em, in the list_options function.
> 
> The patch is OK with those changes.

Done and commited, thanks for reviewing Ian.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]