This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: RFC: Unify overflow checking
- From: David Miller <davem at davemloft dot net>
- To: drow at false dot org
- Cc: binutils at sourceware dot org
- Date: Tue, 22 Apr 2008 15:10:35 -0700 (PDT)
- Subject: Re: RFC: Unify overflow checking
- References: <20080422140755.GA7126@caradoc.them.org>
From: Daniel Jacobowitz <drow@false.org>
Date: Tue, 22 Apr 2008 10:07:55 -0400
> Does anyone remember why bfd_check_overflow and _bfd_relocate_contents
> have different overflow checks? It looks to me as if the ones in
> _bfd_relocate_contents are always appropriate, and bfd_check_overflow
> is simply stale. This (untested so far) patch unifies them.
I think this is definitely something that should go through the
testsuite at least most of the ELF backends before being commited.
It looks fine to me personally, but I bet it will trigger some
obscure regression on some ELF target.