This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Bug binutils/6743] PATCH COMMITTED: new variable for malloc
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Craig Silverstein <csilvers at google dot com>
- Cc: binutils at sourceware dot org
- Date: Sun, 13 Jul 2008 18:24:54 -0700
- Subject: Re: [Bug binutils/6743] PATCH COMMITTED: new variable for malloc
- References: <20080713154732.6743.hjl.tools@gmail.com> <20080713235210.19206.qmail@sourceware.org> <20080714001220.6C7E73F305E@localhost>
On Sun, Jul 13, 2008 at 05:12:20PM -0700, Craig Silverstein wrote:
> It turns out a variable I thought would always point to the beginning
> of the malloc-block, can actually change value. This was causing
> crashes in some cases. I've fixed this by adding a new pointer, that
> always points to the malloc-location, so we can always free it safely.
>
> I'm comitting this under the "obvious fix" principle. This is
> probably the least obvious of the obvious fixes I've done so far, but
> I hope it still safely falls into that category.
>
> craig
>
> --cut here--
>
> 2008-07-13 Craig Silverstein <csilvers@google.com>
>
> * dwarf2.c (struct dwarf2_debug): New variable info_ptr_memory.
> (find_line): Use info_ptr_memory instead of sec_info_ptr.
> (_bfd_dwarf2_cleanup_debug_info): Likewise.
>
>
Hi Craig,
Thanks for fixing both PR ld/6741 and PR binutils/6743. I added
those PRs in your ChangeLog entries.
H.J.