This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Missing spu_ovl.o should abort the build
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Jan Kratochvil" <jan dot kratochvil at redhat dot com>
- Cc: "Alan Modra" <amodra at bigpond dot net dot au>, binutils at sourceware dot org
- Date: Wed, 30 Jul 2008 12:07:48 -0700
- Subject: Re: [patch] Missing spu_ovl.o should abort the build
- References: <20080730183441.GA26838@host0.dyn.jankratochvil.net>
Hi,
spu_ovl.o was left out because binary file isn't supported by "cvs rdiff". It
isn't included in any diff files between releases. Personally, I think
all binary
files in CVS should be stored as text and converted to binary during build or
configure time.
H.J.
---
On Wed, Jul 30, 2008 at 11:34 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> currently --enable-targets=spu from H.J. Lu's binutils snapshot will
> successfully build but with empty spu_ovl.o content. Assuming the SPU target
> will be broken and so we should rather abort the build.
>
>
> Regards,
> Jan
>
> 2008-07-30 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * emultempl/spuelf.em: Abort on the missing required `spu_ovl.o'.
>
> --- ./ld/emultempl/spuelf.em 19 Jun 2008 16:14:53 -0000 1.24
> +++ ./ld/emultempl/spuelf.em 30 Jul 2008 18:28:25 -0000
> @@ -57,7 +57,12 @@ char **my_argv;
> static const char ovl_mgr[] = {
> EOF
>
> -../binutils/bin2c < ${srcdir}/emultempl/spu_ovl.o >> e${EMULATION_NAME}.c
> +if ! ../binutils/bin2c < ${srcdir}/emultempl/spu_ovl.o >> e${EMULATION_NAME}.c
> +then
> + echo >&2 "Missing ${srcdir}/emultempl/spu_ovl.o"
> + echo >&2 "You must build gas/as-new with --target=spu to build spu_ovl.o"
> + exit 1
> +fi
>
> fragment <<EOF
> };
>
>
--
H.J.