This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: allow 1- and 0-operand forms of fcomip and fucomip


On Wed, Aug 27, 2008 at 9:11 AM, Jan Beulich <jbeulich@novell.com> wrote:
>>>> "H.J. Lu" <hjl.tools@gmail.com> 27.08.08 17:54 >>>
>>On Wed, Aug 27, 2008 at 7:58 AM, Jan Beulich <jbeulich@novell.com> wrote:
>>> While the gas extended mnemonics fcompi and fucompi allow for simplified
>>> 1- or 0-operand forms, the 'official' mnemonics fcomip and fucomip didn't.
>>>
>>> Built and tested on i686-pc-linux-gnu.
>>>
>>> opcodes/
>>> 2008-08-27  Jan Beulich  <jbeulich@novell.com>
>>>
>>>        * i386-opc.tbl: Add 1- and 0-operand forms of fcomip and fucomip.
>>>        * i386-tbl.h: Re-generate.
>>>
>>
>>Do you have a reason to add this extension?
>
> Consistency with fcomp/fucomp and consistency with other assemblers
> that allow this.
>

I really don't like those x87 gas extensions. It makes it harder to look them
up in IA32/Intel64 SDM. I don't think we should add more unless we can't
live without them.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]