This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Allow targets to override diff expression generation in w2gencfi.c
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: binutils at sourceware dot org, rth at twiddle dot net, sje at cup dot hp dot com
- Date: Sun, 31 Aug 2008 09:12:56 +0930
- Subject: Re: [PATCH] Allow targets to override diff expression generation in w2gencfi.c
- References: <20080830181023.4F9234DF8@hiauly1.hia.nrc.ca>
On Sat, Aug 30, 2008 at 02:10:22PM -0400, John David Anglin wrote:
> * dw2gencfi.c (CFI_DIFF_EXPR_OK): Define if not defined.
> (dot_cfi_personality): Use CFI_DIFF_EXPR_OK instead of DIFF_EXPR_OK.
> (dot_cfi_lsda, output_cie, output_fde): Likewise.
> * config/tc-hppa.h (CFI_DIFF_EXPR_OK): Define.
OK, except..
> @@ -1157,7 +1166,7 @@ output_fde (struct fde_entry *fde, struc
> exp.X_op_symbol = cie->start_address;
> emit_expr (&exp, 4); /* CIE offset. */
>
> -#ifdef DIFF_EXPR_OK
> +#ifdef CFI_DIFF_EXPR_OK
> exp.X_add_symbol = fde->start_address;
> exp.X_op_symbol = symbol_temp_new_now ();
> emit_expr (&exp, DWARF2_FDE_RELOC_SIZE); /* Code offset. */
> @@ -1185,7 +1194,7 @@ output_fde (struct fde_entry *fde, struc
> exp = fde->lsda;
> if ((fde->lsda_encoding & 0x70) == DW_EH_PE_pcrel)
> {
> -#ifdef DIFF_EXPR_OK
> +#ifdef CFI_DIFF_EXPR_OK
> exp.X_op = O_subtract;
> exp.X_op_symbol = symbol_temp_new_now ();
> emit_expr (&exp, augmentation_size);
Shouldn't these two use #if rather than #ifdef?
--
Alan Modra
Australia Development Lab, IBM