This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix double-counting of MIPS dynamic relocs
- From: David Daney <ddaney at avtrex dot com>
- To: binutils at sourceware dot org, rdsandiford at googlemail dot com
- Date: Thu, 18 Sep 2008 21:14:51 -0700
- Subject: Re: Fix double-counting of MIPS dynamic relocs
- References: <874p5xsylf.fsf@firetop.home>
Richard Sandiford wrote:
> I was updating the GOT patches to work with:
>
> http://sources.redhat.com/ml/binutils/2008-07/msg00350.html
>
> and noticed that that patch double-counted relocations against
> versioned symbols. The hash table callback is called for both
> the indirect and direct definitions, and was reserving relocations
> for both.
>
> This is just a (small) pessimisation at the moment, but it
> triggered an assert I added in the GOT patches.
>
> Tested on mips64-linux-gnu (both with GCC and binutils).
> OK to install?
>
> Richard
>
>
> bfd/
> * elfxx-mips.c (allocate_dynrelocs): Ignore indirect and warning
> symbols.
>
> ld/testsuite/
> * ld-mips-elf/reloc-estimate-1.d, ld-mips-elf/reloc-estimate-1.ld,
> ld-mips-elf/reloc-estimate-1a.s, ld-mips-elf/reloc-estimate-1b.s:
> New test.
> * ld-mips-elf/mips-elf.exp: Run it.
>
Is this new test expected to pass on a mipsel-linux-gnu cross?
With the binutils-2.18.91 snapshot it is failing for me.
I may be able to look at it in a couple of days, but you might have a
better idea of what is going wrong.
David Daney