This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix build with --enable-elf-stt-common

Hi Nix,

The fix is obvious, if inelegant; however, this makes me wonder how
often --enable-elf-stt-common is tested.

Obviously not very often. I have now added a build configured with --enable-elf-stt-common to my binutils build farm, so it will get tested in the future.

This bug was introduced in
*February* and there's no way compilation worked after that. Is this
configure option and related code dead?

No, but it has been lacking in attention. The STT_COMMON ELF symbol type is the correct way to indicate commons, so this code does need to be maintained. Maybe when a new target is added to the binutils this option should be enabled by default for it ... hmm.

2008-11-18 Nix <nix@esperi.org.uk>

* elf.c (swap_out_syms) [USE_STT_COMMON]: Fix syntax error.

Approved and applied.

Cheers
  Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]