This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold][patch] Change how to specify options for the plugins
- From: Ian Lance Taylor <iant at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: binutils at sourceware dot org, Cary Coutant <ccoutant at google dot com>
- Date: Thu, 04 Dec 2008 21:27:18 -0800
- Subject: Re: [gold][patch] Change how to specify options for the plugins
- References: <38a0d8450812040321u3c21c126wfa622ca756608a07@mail.gmail.com>
Rafael Espindola <espindola@google.com> writes:
> 2008-12-04 Rafael Avila de Espindola <espindola@google.com>
>
> * options.cc (General_options::parse_plugin_opt): New.
> (General_options::add_plugin): The argument now is just the filename.
> (General_options::add_plugin_option): New.
> * options.h (plugin_opt): New.
> (add_plugin): Change argument name.
> (add_plugin_option): New.
> * plugin.cc (Plugin::load): Don't parse the plugin option.
> * plugin.h (Plugin::Plugin): Rename argument. Init filename_.
> (Plugin::add_option): New.
> (Plugin::args_): Change type.
> (Plugin::filename_): New.
> (Plugin_manager::add_plugin_option): New.
> * testsuite/Makefile.am (plugin_test_1): Use new syntax.
> * testsuite/Makefile.in: Regenerate.
> +
> +//Parse --plugin-opt.
> +
Please add a space between "//" and "Parse".
> + DEFINE_special(plugin_opt, options::TWO_DASHES, '\0',
> + N_("pass an option to the plugin"), N_("OPTION"));
Please capitalize "pass".
This is OK with those changes.
Thanks.
Ian