This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Update mtfsf and mtfsfi instructions to support new optional operands.
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: binutils at sourceware dot org, Segher Boessenkool <segher at kernel dot crashing dot org>
- Date: Wed, 14 Jan 2009 22:32:35 -0600
- Subject: Re: [PATCH] Update mtfsf and mtfsfi instructions to support new optional operands.
- References: <20070515213441.GA4052@vervain.rchland.ibm.com> <e80a11b08fce3da1e15053808c88130f@kernel.crashing.org> <1231970875.7969.3.camel@otta> <20090114222123.GC9026@bubble.grove.modra.org>
On Thu, 2009-01-15 at 08:51 +1030, Alan Modra wrote:
> On Wed, Jan 14, 2009 at 04:07:55PM -0600, Peter Bergner wrote:
> > opcodes/
> > * ppc-dis.c (print_insn_powerpc): Skip insn if it is deprecated.
> > * ppc-opc.c (powerpc_opcodes) <mtfsf, mtfsf.>: Deprecate the two
> > operand form and enable the four operand form for POWER6 and later.
> > <mtfsfi, mtfsfi.>: Deprecate the two operand form and enable the
> > three operand form for POWER6 and later.
> >
> > gas/testsuite/
> > * gas/ppc/power6.s ("mtfsf", "mtfsf.", "mtfsfi", "mtfsfi."): Add tests.
> > * gas/ppc/power6.d: Likewise.
>
> OK, but..
[snip]
> Reorder this with the two "mtfsfi" followed by two "mtfsfi." Similarly
> for mtfsf. I'm trying to keep the table ordered by opcode as much as
> possible. (See gas/config/tc-ppc.c:1356.)
Ack, I should have caught that, since I know we're trying to keep it sorted.
Thanks for catching it and I just committed the updated patch. Thanks.
Peter