This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update mtfsf and mtfsfi instructions to support new optional operands.


On Thu, 2009-01-15 at 08:51 +1030, Alan Modra wrote:
> On Wed, Jan 14, 2009 at 04:07:55PM -0600, Peter Bergner wrote:
> > opcodes/
> > 	* ppc-dis.c (print_insn_powerpc): Skip insn if it is deprecated.
> > 	* ppc-opc.c (powerpc_opcodes) <mtfsf, mtfsf.>: Deprecate the two
> > 	operand form and enable the four operand form for POWER6 and later.
> > 	<mtfsfi, mtfsfi.>: Deprecate the two operand form and enable the
> > 	three operand form for POWER6 and later.
> > 
> > gas/testsuite/
> > 	* gas/ppc/power6.s ("mtfsf", "mtfsf.", "mtfsfi", "mtfsfi."): Add tests.
> > 	* gas/ppc/power6.d: Likewise.
> 
> OK, but..
[snip]
> Reorder this with the two "mtfsfi" followed by two "mtfsfi."  Similarly
> for mtfsf.  I'm trying to keep the table ordered by opcode as much as
> possible.  (See gas/config/tc-ppc.c:1356.)

Ack, I should have caught that, since I know we're trying to keep it sorted.
Thanks for catching it and I just committed the updated patch.  Thanks.

Peter




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]