This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][M68K] Binutils support for TLS


Maxim Kuvyrkov wrote:

...

It is better to just remove this field as it is not very useful now. To keep the assert and make it reliable, it is enough to set arg->offset2[-N] to the values of arg->offset2[N] when negative offsets are not used.

+  if (!use_neg_got_offsets_p)
+    /* Make sure that if we try to switch to negative offsets in
+       elf_m68k_finalize_got_offsets_1, the assert therein will catch
+       the bug.  */
+    {
+      for (i = (int) R_8; i < (int) R_32; ++i)
                               ^
               This should be "<=".
+	arg_.offset2[-i - 1] = arg_.offset2[i];
+    }
+

-- Maxim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]