Re: Thumb-2 assembler fixes, 0/5

[David Daney <ddaney at caviumnetworks dot com>]

Mark Mitchell wrote:
> Nick Clifton wrote:
>
> > Note - since Mark is a binutils ARM maintainer, and all of the these
> > patches are ARM specific, he could just apply the patches himself.  (Or
> > even ask you to apply them on his behalf).
>
> I believe I'm only a maintainer for the ARM SymbianOS aspects of
> Binutils.  So, I don't think I get to approve patches for the generic
> ARM bits.
>
> A related policy question, though, is whether a patch needs to be
> re-approved if it's already been reviewed by an FSF maintainer when it
> went into our internal tree.  For example, if Paul reviewed the patch
> when it was written, does it need to be re-reviewed when contributed?
>
> I don't have an opinion; the obvious trade-off is between more review (a
> good thing, in general) and more work (not such a good thing).

If the review and approval are in the public record (mailing-list, 
bugzilla comment, etc.), then it seems that an additional review serves 
no purpose.

On the other hand, if there is no public record, people are left 
wondering if proper approval procedures have been followed.  At a 
minimum I would say where and when it was approved (even if the approval 
occurred in a private forum).

David Daney