This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: add --incremental, --incremental-changed, --incremental-unchanged and --incremental-unknown command line options
- From: Ian Lance Taylor <iant at google dot com>
- To: Mikolaj Zalewski <mikolajz at google dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 06 Feb 2009 07:54:49 -0800
- Subject: Re: [PATCH] gold: add --incremental, --incremental-changed, --incremental-unchanged and --incremental-unknown command line options
- References: <7ebec9e70902051547k40203a5j20a3d5e6f28bbfc6@mail.gmail.com>
Mikolaj Zalewski <mikolajz@google.com> writes:
> This patch adds the incremental command line options. They have no
> effect yet. The --incremental-* disposition is stored in the
> Input_file_argument. Files added by plug-ins and scripts are always
> --incremental-unknowns. The latter causes -lXXX libraries to be always
> --incremental-unknown. I can look into it later, but I wanted to show
> the patch already in case there are some problems with the approach
> and the patch needs to be made differently. Specifying --incremental-*
> without --incremental is considered an error.
Thanks. You're adding --incremental-* to General_options, but it should
really be in Position_dependent_options. If you do that you shouldn't
need to change the Input_file_argument constructor.
Ian