This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold][patch] Small code refactoring

From: Rafael Espindola <espindola at google dot com>
To: Cary Coutant <ccoutant at google dot com>
Cc: binutils at sourceware dot org
Date: Fri, 13 Feb 2009 09:33:54 +0000
Subject: Re: [gold][patch] Small code refactoring
References: <38a0d8450902120336p346b73a7y26a966cdf1eb9056@mail.gmail.com> <c17be2b30902121547r4075f08pf4f9d63384795801@mail.gmail.com>

> This looks reasonable to me, but I'm not a big fan of the name
> "make_elf_object2". How about calling the new one something like
> "recognize_and_make_elf_object"? Maybe Ian will have a better
> suggestion.

One thing I considered was to inline make_elf_object2 since it has
only one call site in the program. Ian, what do you think?

> -cary
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047

References:
- [gold][patch] Small code refactoring
  - From: Rafael Espindola
- Re: [gold][patch] Small code refactoring
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]