This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: make the kept comdat structure have a direct link to sections map
- From: Cary Coutant <ccoutant at google dot com>
- To: Mikolaj Zalewski <mikolajz at google dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 27 Feb 2009 11:19:39 -0800
- Subject: Re: [PATCH] gold: make the kept comdat structure have a direct link to sections map
- References: <7ebec9e70902270725y77c1a95ck31fcb1ff89fe1a90@mail.gmail.com>
> 2009-02-27 ?Mikolaj Zalewski ?<mikolajz@google.com>
> ? ? ? ?* layout.cc (find_or_add_comdat): a more generic version of add_comdat
> ? ? ? ?(add_comdat): removed
> ? ? ? ?* layout.h (Kept_section): move out of Layout
> ? ? ? ?(Kept_section::group_sections_): new field
> ? ? ? ?(Layout::Kep_section): remove
"Kept_section"
> ? ? ? ?(find_or_add_comdat): a more generic version of add_comdat
> ? ? ? ?(add_comdat): removed
> ? ? ? ?* object.cc (include_section_group): use find_or_add_comdat and
> Kept_section::group_sections_
> ? ? ? ?(include_linkonce_section): use find_or_add_comdat and
> Kept_section::group_sections_
> ? ? ? ?* object.cc (Comdat_group): removed
> ? ? ? ?(Comdat_group_table): removed
> ? ? ? ?(find_comdat_grouop): removed
> ? ? ? ?(add_comdat_group): removed
> ? ? ? ?(comdat_groups_): removed
> ? ? ? ?* plugin.cc (include_comdat_group): use the new Layout::find_or_add_comdat
Your patch looks good to me -- a definite improvement. Thanks!
(I don't have authority to approve, though -- wait for Ian's comments.)
-cary