Re: [PATCH/BUGFIX] GDB needs long PE section names enabled.

[Dave Korn <dave dot korn dot cygwin at googlemail dot com>]

Christopher Faylor wrote:
> On Tue, Mar 03, 2009 at 01:02:12PM +0000, Dave Korn wrote:
>> Dave Korn wrote:
>>
>>>   Tested that this patch works on i686-pc-cygwin both by looking at the
>>> section names with objdump and by debugging a linked exe with gdb and
>>> observing whether or not it reported debug info present - see attached.  Now
>>> running crossbuilds and regtests from i686-pc-linux-gnu to {arm-epoc-pe,
>>> arm-wince-pe, i386-pc-netbsdpe, i386-pc-pe, i586-pc-interix,
>>> i586-unknown-beospe, i686-pc-cygwin, i686-pc-mingw32, mcore-unknown-pe,
>>> powerpcle-unknown-pe, sh-unknown-pe, thumb-epoc-pe, x86_64-pc-freebsd,
>>> x86_64-pc-linux-gnu, x86_64-pc-mingw32}.
>>  All passed, no regressions.
> 
> Since this is Windows related, I think I'm allowed to say: Go ahead and
> check this in.
> 
> cgf

  Thanks, I'm sure you are.  I forgot the ChangeLog first time round:

ld/ChangeLog:

	* emultempl/pe.em (debug_section_p):  New bfd_map_over_sections hook.
	(gld_${EMULATION_NAME}_after_open):  Use it to iterate all sections
	of all input BFDs, looking for debug info.  Enable long section names
	if any found.
	* emultempl/pe.em (debug_section_p):  Likewise.
	(gld_${EMULATION_NAME}_after_open):  Likewise.
	* NEWS:  Retrospectively adjust news announcement.
	* ld.texinfo:  Update documentation to mention new behaviour.

  Applying now.

    cheers,
      DaveK