This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix power7 ppc64 binaries loading
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: Peter Bergner <bergner at vnet dot ibm dot com>, Daniel Jacobowitz <drow at false dot org>, Thiago Jung Bauermann <bauerman at br dot ibm dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Tue, 3 Mar 2009 23:54:18 +0000 (UTC)
- Subject: Re: [patch] Fix power7 ppc64 binaries loading
- References: <20090302210237.GA23798@host0.dyn.jankratochvil.net> <20090302212403.GA3473@caradoc.them.org> <20090302213340.GA7433@host0.dyn.jankratochvil.net> <1236111881.30573.61.camel@localhost.localdomain> <20090303203050.GA2551@caradoc.them.org> <1236113699.6800.61.camel@otta> <20090303231626.GB9491@bubble.grove.modra.org> <Pine.LNX.4.64.0903032329050.15240@digraph.polyomino.org.uk> <20090303234833.GE9491@bubble.grove.modra.org>
On Wed, 4 Mar 2009, Alan Modra wrote:
> On Tue, Mar 03, 2009 at 11:30:27PM +0000, Joseph S. Myers wrote:
> > On Wed, 4 Mar 2009, Alan Modra wrote:
> >
> > > Google for E500 ABI. It should only be enabled when you are
> > > assembling for e500. I've committed the following to mainline
> > > and 2.19 branch.
> > >
> > > * config/tc-ppc.c (md_assemble): APUinfo only for e500.
> >
> > > - if (ppc_cpu & (PPC_OPCODE_SPE
> > > - | PPC_OPCODE_ISEL | PPC_OPCODE_EFS
> > > - | PPC_OPCODE_BRLOCK | PPC_OPCODE_PMR | PPC_OPCODE_CACHELCK
> > > - | PPC_OPCODE_RFMCI))
> > > + if ((ppc_cpu & PPC_OPCODE_E500MC) != 0)
> >
> > Most e500 are not e500mc (indeed, e500mc is mostly like classic PowerPC at
> > the userspace level, not like e500).
>
> The effect of the new test is to generate .PPC.EMB.apuinfo when
> gas is given any of -me500, -me500x2 or -me500mc options. Is that
> not correct? I freely admit to not being 100% certain.
That seems correct; it just seems odd for PPC_OPCODE_E500MC to apply also
to the other e500 processors.
--
Joseph S. Myers
joseph@codesourcery.com