This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch PE-COFF]: Some minor nits


Hello,

Some minor nits I found in coffcode.h. One is that debugging sections have 
to have readonly flag set (abstracted by the section flags of '.debug' in 
pe-coff spec).
Secondly a clean-up about NOREAD sections. I introduced a helper flag for 
section's flags to indicated, that a section has no memory flag set,
I tested this patch for i686-pc-cygwin and for x86_64-pc-ming32 and saw no 
regressions on testrun.

ChangeLog
2009-03-13  Kai Tietz  <kai.tietz@onevision.com>

        * bfd-in2.h: Regenerated.
        * coffcode.h (sec_to_styp_flags): For pe-coff add SEC_READONLY
        for debugging sections and map memory read/write dependent on
        SEC_COFF_NOREAD.
        (styp_to_sec_flags): Set SEC_COFF_NOREAD for sections
        without memory read flags set.
        * section.c: Add SEC_COFF_NOREAD to section flags.

Is this patch ok for apply?
 
Cheers,
Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: noread.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]