This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] fix bfd multi-arch compilation failure
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Tue, 17 Mar 2009 16:59:26 -0700
- Subject: Re: [RFA] fix bfd multi-arch compilation failure
- References: <005001c9a757$db6bacb0$92430610$@u-strasbg.fr>
On Tue, Mar 17, 2009 at 4:26 PM, Pierre Muller <muller@ics.u-strasbg.fr> wrote:
> Hi,
> I tried to do a compilation of
> gdb with --enable-targets=all --enable-64-bits-bfd
> on OpenSolaris 2008.11.
>
> I found two problems in bfd directory,
> related to uses of alloca without
> including <alloca.h>
>
> I added
> #include <alloca.h>
> garded by #ifdef HAVE_ALLOCA_H
> as I suppose that on some systems
> alloca is builtin and thus does not require any header.
>
>
> Is this OK to check in?
>
>
> Pierre Muller
> Pascal language support maintainer for GDB
>
>
>
> ChangeLog entry:
>
> 2009-03-18 ?Pierre Muller ?<muller@ics.u-strasbg.fr>
>
> ? ? ? ?* elf32-m68hc1x.c: Add alloca header.
> ? ? ? ?* xsym.c: Ditto.
>
>
> Index: bfd/elf32-m68hc1x.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-m68hc1x.c,v
> retrieving revision 1.33
> diff -u -p -r1.33 elf32-m68hc1x.c
> --- bfd/elf32-m68hc1x.c 12 Mar 2008 08:36:59 -0000 ? ? ?1.33
> +++ bfd/elf32-m68hc1x.c 17 Mar 2009 23:18:58 -0000
> @@ -20,6 +20,9 @@
> ? ?Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
> ? ?MA 02110-1301, USA. ?*/
>
> +#ifdef HAVE_ALLOCA_H
> +#include <alloca.h>
> +#endif
> ?#include "sysdep.h"
> ?#include "bfd.h"
> ?#include "bfdlink.h"
That is wrong. Please see how it is handled in elf64-hppa.c.
--
H.J.