This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Add discriminator support to gas .loc directive
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Nick Clifton <nickc at redhat dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 01 Jul 2009 00:27:56 +0100
- Subject: Re: [patch] Add discriminator support to gas .loc directive
- References: <c17be2b30904201838nbb02752r9372787844a1634e@mail.gmail.com> <49ED7B85.7060606@redhat.com> <c17be2b30904211027w3e8359aen7cdf268cfee5b7f1@mail.gmail.com> <c17be2b30904211146u2f4c8ed2m967ca5d95d665318@mail.gmail.com> <49F16BFA.3040201@redhat.com> <c17be2b30904241133v1dc5a2a4s9484dda8bf5c1674@mail.gmail.com> <4A49F5A4.3040209@gmail.com> <c17be2b30906301338o34710fc8jf28067e603e8588b@mail.gmail.com>
Cary Coutant wrote:
> The quickest fix is to have decode_line_info just ignore the
> discriminator. A proposed patch for that is below; I ran the binutils
> testsuite with a discriminator-generating compiler, but I don't see
> any failures with or without this fix -- there don't seem to be any
> tests for addr2line. Could you give this patch a try and see if it
> works for you?
Just skipping over without complaining seems a totally proper fix IMO. I'll
give it a check tomorrow, it's a bit late at night in my local $TZ :) Thanks
for getting back to me.
cheers,
DaveK