This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] Fix PE/x86 debug info problems.
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 03 Jul 2009 17:23:13 +0100
- Subject: [committed] Fix PE/x86 debug info problems.
After extensive testing and discussion offlist, Kai and I have agreed to
revert the problematic patch to coffcode.h. I just committed the attached patch.
bfd/ChangeLog:
2009-07-03 Dave Korn <dave.korn.cygwin@gmail.com>
* coffcode.h (sec_to_styp_flags): Partially revert (functional
changes only) earlier patch:-
2009-06-25 Kai Tietz <kai.tietz@onevision.com>
* coffcode.h (sec_to_styp_flags): Set discardable for .reloc and
give .debug and .reloc data characteristics.
(DOT_RELOC): New define for .reloc section string.
(coff_write_object_contents): Use DOT_RELOC instead of string.
cheers,
DaveK
Index: bfd/coffcode.h
===================================================================
RCS file: /cvs/src/src/bfd/coffcode.h,v
retrieving revision 1.156
diff -p -u -r1.156 coffcode.h
--- bfd/coffcode.h 25 Jun 2009 13:39:27 -0000 1.156
+++ bfd/coffcode.h 3 Jul 2009 15:48:22 -0000
@@ -646,12 +646,7 @@ sec_to_styp_flags (const char *sec_name,
/* FIXME: There is no gas syntax to specify the debug section flag. */
if (CONST_STRNEQ (sec_name, DOT_DEBUG)
|| CONST_STRNEQ (sec_name, GNU_LINKONCE_WI))
- sec_flags = SEC_DATA | SEC_LOAD | SEC_ALLOC | SEC_DEBUGGING | SEC_READONLY;
- else if (CONST_STRNEQ (sec_name, DOT_RELOC))
- {
- sec_flags = SEC_DATA | SEC_LOAD | SEC_ALLOC | SEC_READONLY;
- styp_flags |= IMAGE_SCN_MEM_DISCARDABLE;
- }
+ sec_flags = SEC_DEBUGGING | SEC_READONLY;
/* skip LOAD */
/* READONLY later */