This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] give .comment sections SHF_MERGE|SHF_STRINGS
> It only seems to work if I explicitly set the section entsize to 1.
Oh, I guess that's reasonable enough. So I take this to mean you've tested
this version and declare it good?
Ok to commit tested version?
2009-07-24 Roland McGrath <roland@redhat.com>
Mark Wielaard <mjw@redhat.com>
* config/obj-elf.c (obj_elf_ident): Set SEC_MERGE | SEC_STRINGS
flags on .comment section.
Index: obj-elf.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-elf.c,v
retrieving revision 1.115
diff -u -b -p -r1.115 obj-elf.c
--- obj-elf.c 23 Jul 2009 13:00:27 -0000 1.115
+++ obj-elf.c 24 Jul 2009 22:37:01 -0000
@@ -1723,7 +1723,9 @@ obj_elf_ident (int ignore ATTRIBUTE_UNUS
char *p;
comment_section = subseg_new (".comment", 0);
bfd_set_section_flags (stdoutput, comment_section,
- SEC_READONLY | SEC_HAS_CONTENTS);
+ SEC_READONLY | SEC_HAS_CONTENTS
+ | SEC_MERGE | SEC_STRINGS);
+ comment_section->entsize = 1;
p = frag_more (1);
*p = 0;
}