This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[COMMITED][GOLD] Revert change in dynobj.h
- From: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?= <dougkwan at google dot com>
- To: binutils at sourceware dot org
- Cc: Sriraman Tallam <tmsriram at google dot com>, Ian Lance Taylor <iant at google dot com>, Cary Coutant <ccoutant at google dot com>
- Date: Sun, 9 Aug 2009 19:35:48 -0700
- Subject: [COMMITED][GOLD] Revert change in dynobj.h
Hi,
I have just committed the patch is this mail to revert:
http://sourceware.org/ml/binutils-cvs/2009-08/msg00043.html
Ian thinks that patch should not be checked in.
>I'm not sure if this went in already, but this patch should not go in.
>Using gold_unreachable should be enough for the compiler to know that
>the function does not return. If using a compiler which does not
>understand that, the compiler should not be using warning flags. I
>would prefer to see an autoconf test to control the warning options,
>rather than adding this useless return statement to the function.
>
>Ian
-Doug
2009-08-09 Doug Kwan <dougkwan@google.com>
* dynobj.h (Sized_dynobj::do_section_entsize): Revert the previous
patch.
Index: gold/dynobj.h
===================================================================
RCS file: /cvs/src/src/gold/dynobj.h,v
retrieving revision 1.30
diff -u -r1.30 dynobj.h
--- gold/dynobj.h 7 Aug 2009 18:48:44 -0000 1.30
+++ gold/dynobj.h 10 Aug 2009 02:28:26 -0000
@@ -201,7 +201,7 @@
// Not used for dynobj.
uint64_t
do_section_entsize(unsigned int )
- { gold_unreachable(); return 0; }
+ { gold_unreachable(); }
// Return section address.
uint64_t