This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gold: add cast to gold_unreachable to workaround gcc giving invalid "no return statement" warnings


  Yes, this patch works.

MikoÅaj

On Fri, Aug 14, 2009 at 10:34 AM, Ian Lance Taylor<iant@google.com> wrote:
> Mikolaj Zalewski <mikolajz@google.com> writes:
>
>> Â I couldn't compile gold today because of the "no return statement"
>> warning when using gold_unreachable. At
>> http://gcc.gnu.org/ml/gcc-bugs/2007-11/msg01605.html I've found a
>> workaround that should work for gcc >= 3.4. Such a patch that affects
>> only gold_unreachable is ok?
>>
>> 2009-08-13 ÂMikolaj Zalewski Â<mikolajz@google.com>
>>
>> Â Â Â * gold.h (gold_unreachable): Add a cast.
>
> I would prefer a patch like this one, which gives us a way to clean it
> up a few years down the road. ÂCould you check whether this solves the
> problem for you? ÂIf it does, I'll commit it. ÂThanks.
>
> Ian
>
>
> 2009-08-14 ÂIan Lance Taylor Â<iant@google.com>
>
> Â Â Â Â* gold.h (FUNCTION_NAME): Define.
> Â Â Â Â(gold_unreachable): Use FUNCTION_NAME.
>
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]