Re: [patch gas]: Add pseudos for generation of runtime function entries by gas

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Tue, Aug 18, 2009 at 8:01 AM, Kai Tietz<ktietz70@googlemail.com> wrote:
> 2009/8/18 H.J. Lu <hjl.tools@gmail.com>:
>> On Tue, Aug 18, 2009 at 7:41 AM, H.J. Lu<hjl.tools@gmail.com> wrote:
>>> On Mon, Aug 17, 2009 at 4:49 AM, Kai Tietz<ktietz70@googlemail.com> wrote:
>>>> 2009/8/17 Nick Clifton <nickc@redhat.com>:
>>>>> Hi Kai,
>>>>>
>>>>>> Ups, I found one typo within patch file, which prevents build. So here
>>>>>> the update of the patch.
>>>>>
>>>>> Approved - please apply.
>>>>>
>>>>> Just FYI - I am not a fan of prototypes for static functions, eg:
>>>>>
>>>>> ?static seh_kind seh_get_target_kind (void);
>>>>>
>>>>> Most of the time these are unnecessary - just make sure that the function is
>>>>> defined before it is used. ?Having the prototype does not help the compiler,
>>>>> wastes space in the source file and means that there are two places to edit
>>>>> when changing the parameters or return type of the function. ?Of course
>>>>> there are situations where the prototype is needed, such as mutual
>>>>> recursion, but these are the exception rather than the rule.
>>>>>
>>>>> Cheers
>>>>> ?Nick
>>>>>
>>>>
>>>> Well, I liked to group those functions, therefore I added those static
>>>> function prototypes. But I'll begin to clean them up, so that just the
>>>> necessary ones are remaining.
>>>>
>>>> Thanks for reviewing, applied.
>>>
>>> It breaks Windows cross binutils:
>>>
>>> http://sourceware.org/bugzilla/show_bug.cgi?id=10534
>>>
>>
>> There are no FSF copyright notices in obj-coff-seh.c nor obj-coff-seh.h.
>>
>> --
>> H.J.
>>
>
> Does this patch fixes your build?
>
> ChangeLog
>
> 2009-08-18 ?Kai Tietz ?<kai.tietz@onevision.com>
>
> ? ? ? ?* config/obj-coff-seh.c: Add copyright notice.
> ? ? ? ?* config/obj-coff-seh.h: Add copyright notice.
> ? ? ? ?Add x64 specific macros from coff/pe.h header.
>

It works for me.

Thanks.


-- 
H.J.