This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Handle extrdi and large register rotate values
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 28 Aug 2009 09:45:01 +0930
- Subject: Re: Handle extrdi and large register rotate values
- References: <1251412176.5257.51.camel@otta>
On Thu, Aug 27, 2009 at 05:29:36PM -0500, Peter Bergner wrote:
> -{"extrdi", 4, PPC64, "rldicl %0,%1,(%2)+(%3),64-(%2)"},
> -{"extrdi.", 4, PPC64, "rldicl. %0,%1,(%2)+(%3),64-(%2)"},
> +{"extrdi", 4, PPC64, "rldicl %0,%1,((%2)+(%3))&0x3f,64-(%2)"},
> +{"extrdi.", 4, PPC64, "rldicl. %0,%1,((%2)+(%3))&0x3f,64-(%2)"},
>
> but that would mean updating quite a few other ops similarly. Is the
> following patch acceptable to catch them all in one shot or do you
> prefer a change like the above?
I prefer this. For your other patch, you'd need to argue that the
current warning on plain rldicl shift counts isn't useful.
--
Alan Modra
Australia Development Lab, IBM