This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts
On Thu, Aug 27, 2009 at 08:55:46PM -0700, H.J. Lu wrote:
> On Thu, Aug 27, 2009 at 8:32 PM, H.J. Lu<hjl.tools@gmail.com> wrote:
> > On Thu, Aug 27, 2009 at 8:14 PM, Alan Modra<amodra@bigpond.net.au> wrote:
> >> I think this is the wrong place to call bfd_emul_set_maxpagesize
> >> (and the current call in elf32.em is wrong too). ?You probably should
> >> be calling bfd_emul_set_maxpagesize in open_output. ?Also,
> >
> > Will open_output be called before any linker scripts are processed?
Depends on what you mean by processed. Yes, they are parsed and
converted to internal format before open_output, but why does it
matter? Nothing much depends on maxpagesize until
lang_size_sections.
Perhaps even a nicer patch would be to put your
bfd_emul_set_maxpagesize calls in a LD_EMUL_SET_OUTPUT_ARCH hook,
which is called just after open_output.
> >> bfd_emul_get_maxpagesize in fold_name shouldn't be using
> >> default_target. ?Ditto for commonpagesize.
> >>
> >
> > That is true. I will fix it.
>
> There is no easy fix. Should we just set max/common page sizes for
> all enabled ELF targets?
Why can't you use output_target?
--
Alan Modra
Australia Development Lab, IBM