This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Use enum instead of nested macros


On Thu, Oct 15, 2009 at 4:46 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> H.J. Lu wrote:
>>
>> I am checking in this patch to use enum instead of nested macros.
>
> [...]
>>
>> +enum
>> +{
>> + ?REG_80 = 0,
>> + ?REG_81 = REG_80 + 1,
>> + ?REG_82 = REG_81 + 1,
>
> Am I missing something, or is every single one of your ' = foo + 1' in this
> patch completely redundant?

Do all compiler guarantee that bar == 1 with

enum
{
  foo = 0,
  bar
};

If yes, I'd love to get rid of "foo + 1".


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]