This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Use enum instead of nested macros in i386-opc.h

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: David Daney <ddaney at caviumnetworks dot com>
Cc: binutils at sources dot redhat dot com
Date: Fri, 16 Oct 2009 10:41:15 -0700
Subject: Re: PATCH: Use enum instead of nested macros in i386-opc.h
References: <20091016155032.GA18099@lucon.org> <4AD8A9FA.4010907@caviumnetworks.com>

On Fri, Oct 16, 2009 at 10:14 AM, David Daney <ddaney@caviumnetworks.com> wrote:
> H.J. Lu wrote:
> [...]
>>
>> +enum
>> +{
>> + ?/* i186 or better required */
>> + ?Cpu186 = 0,
>
> [...]
>>
>> +enum
>> +{
>> + ?/* has direction bit. */
>> + ?D = 0,
>
> [...]
>>
>> +enum
>> +{
>> + ?/* 8bit register */
>> + ?Reg8 = 0,
>
> Putting on my pedant's hat: All those '= 0' are redundant.
>

I will leave it there if it doesn't hurt.

Thanks.


-- 
H.J.

References:
- PATCH: Use enum instead of nested macros in i386-opc.h
  - From: H.J. Lu
- Re: PATCH: Use enum instead of nested macros in i386-opc.h
  - From: David Daney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]