This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] New ia64 @slotcount pseudo func
- From: "Jan Beulich" <JBeulich at novell dot com>
- To: "Douglas B Rupp" <rupp at gnat dot com>
- Cc: "Nick Clifton" <nickc at redhat dot com>, "Richard Henderson" <rth at redhat dot com>, <binutils at sourceware dot org>
- Date: Thu, 29 Oct 2009 08:11:36 +0000
- Subject: Re: [PATCH] New ia64 @slotcount pseudo func
- References: <4AE8A868.5060908@gnat.com>
>>> Douglas B Rupp <rupp@gnat.com> 28.10.09 21:24 >>>
>Submitted for comment as per previous discussions.
Why can't the debugger do the math that you do here? Unless Intel's
assembler is intending to also support @slotcount, I'm not certain it's a
good idea to add such to gas.
Also:
>+ /* Calculate the number of instruction slots between the two
>+ labels. They are guaranteed to be in the same (.text)
>+ section. */
>+ end = S_GET_VALUE (symbolPend);
>+ beg = S_GET_VALUE (symbolPbeg);
Where is this "guarantee" being enforced? I think you mean "They are
supposed...", and need to check this really is the case.
Jan