This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add a testcase for PR 876


> Date: Wed, 4 Nov 2009 10:49:34 -0800
> From: "H.J. Lu" <hongjiu.lu@intel.com>

> Index: gas/i386/i386.exp
> ===================================================================
> --- gas/i386/i386.exp	(revision 7236)
> +++ gas/i386/i386.exp	(working copy)
> @@ -17,6 +17,9 @@ proc gas_32_check { } {
>      return [regexp "targets:.*i386" [lindex $status 1]];
>  }
>  
> +# Common tests
> +run_list_test "space1" "-al"
> +
>  if [expr ([istarget "i*86-*-*"] ||  [istarget "x86_64-*-*"]) && [gas_32_check]]  then {

This is wrong, you've put the test before the target-gate-test,
so it's attempted on all targets, not just the x86 and
relatives.

My autotester complains about the failure for cris-axis-elf and
cris-axis-linux-gnu:

Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/i386/i386.exp ...
FAIL: i386 space1

gas.log:
regexp_diff match failure
regexp "^GAS LISTING .*$"
line   "GAS for CRIS /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/i386/space1.s                  page 1"
FAIL: i386 space1

(That's due to a target-specific assumption of the default
LISTING_HEADER.)

If you really mean for it to run everywhere, it shouldn't sit in
testsuite/gas/i386 anyways.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]