This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[obv] comment fix for get_file_size()
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: binutils at sourceware dot org
- Date: Mon, 9 Nov 2009 00:05:41 +0100
- Subject: [obv] comment fix for get_file_size()
Hi,
There was a change
PATCH: PR binutils/10321: objcopy silently exits with empty input files
http://sourceware.org/ml/binutils/2009-06/msg00457.html
http://sourceware.org/ml/binutils-cvs/2009-06/msg00205.html
ae371689a784ec78f75061e918c5719c6ba0f0a9
@@ -574,1 +574,1 @@ get_file_size (const char * file_name)
- return 0;
+ return (off_t) -1;
but the function comment was not updated for it. Fixed the comment as obvious.
Thanks,
Jan
http://sourceware.org/ml/binutils-cvs/2009-11/msg00069.html
--- src/binutils/ChangeLog 2009/11/08 21:36:46 1.1558
+++ src/binutils/ChangeLog 2009/11/08 23:01:57 1.1559
@@ -1,3 +1,7 @@
+2009-11-09 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * bucomm.c (get_file_size): Update comment for the error return value.
+
2009-11-08 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* readelf.c (slurp_hppa_unwind_table): Don't relocate address twice.
--- src/binutils/bucomm.c 2009/09/10 13:40:44 1.37
+++ src/binutils/bucomm.c 2009/11/08 23:01:57 1.38
@@ -552,7 +552,7 @@
/* Returns the size of the named file. If the file does not
exist, or if it is not a real file, then a suitable non-fatal
- error message is printed and zero is returned. */
+ error message is printed and (off_t) -1 is returned. */
off_t
get_file_size (const char * file_name)