This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch]: fix bfd/targets.c build failure on AIX
On Tue, Nov 17, 2009 at 02:00:48PM +0100, Tristan Gingold wrote:
> So, do we accept alloca in targets.c ?
I think we could easily use a fixed size buffer, since the code in
bfd_get_target_info is using alloca for (part of) target_vec->name.
The largest target_vec->name is currently 24 chars. A buffer twice
that size should be ample.
> Maybe we should also clearly document in alloca-conf.h that this
> file must be the first include.
We do have a comment that says in part: "Some versions of AIX require
this to be the first thing in the file except for comments and
preprocessor directives."
s/in the file/seen by the compiler/ would be clearer.
--
Alan Modra
Australia Development Lab, IBM