This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add XOP support for upcoming AMD Orochi processor
On Wed, Nov 18, 2009 at 8:16 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi,
>
> On Tue, Nov 17, 2009 at 16:24, Sebastian Pop <sebpop@gmail.com> wrote:
>> I opened a PR http://sourceware.org/bugzilla/show_bug.cgi?id=10973 for
>> a problem that we identified as part of OP_E_memory that also existed
>> before in the FMA4 instructions. ?We discovered this problem in some
>> of the 4 operands XOP tests. ?This bug should be fixed independently
>> of the current patch adding support for XOP instructions.
>
> The attached patch fixes this PR as follows:
>
> 2009-11-18 ?Sebastian Pop ?<sebastian.pop@amd.com>
>
> ? ? ? ?opcodes/
> ? ? ? ?PR binutils/10973
> ? ? ? ?* i386-dis.c (get_vex_imm8): Do not increment codep.
> ? ? ? ?Avoid incrementing bytes_before_imm when OP_E_memory
> ? ? ? ?has already forwarded the codep pointer.
> ? ? ? ?(OP_EX_VexW): Increment codep to skip mod/rm byte.
>
> ? ? ? ?gas/testsuite/
> ? ? ? ?* gas/i386/x86-64-xop.d: Update patterns.
>
> Tested with make -k check. ?I will further test tomorrow on simnow the
> support for XOP and FMA4 instructions and I will add a more extensive
> testsuite also containing the patterns that we avoided because of this
> bug. ?Ok to commit?
>
OK.
--
H.J.