This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold][patch] Move the reader and writer classes to incremental.h
- From: Ian Lance Taylor <iant at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: Binutils <binutils at sourceware dot org>, Mikolaj Zalewski <mikolajz at google dot com>
- Date: Wed, 02 Dec 2009 21:16:36 -0800
- Subject: Re: [gold][patch] Move the reader and writer classes to incremental.h
- References: <38a0d8450912021300m1659c4fdqdf883e2fb6ff174a@mail.gmail.com>
Rafael Espindola <espindola@google.com> writes:
> I changed the classes slightly: They now have a typedef for the
> Convert types. This was done to avoid adding "using elfcpp::Convert"
> to the header file or using more than 80 characters in a line.
>
> 2009-12-02 Rafael Avila de Espindola <espindola@google.com>
>
> * incremental.h (Incremental_inputs_header)
> (Incremental_inputs_header_write, Incremental_inputs_entry,
> Incremental_inputs_entry_write): Move ...
> * incremental.cc (Incremental_inputs_header)
> (Incremental_inputs_header_write, Incremental_inputs_entry,
> Incremental_inputs_entry_write): here.
This is OK, if you fix the ChangeLog entry to indicate that they are
moving from the .cc file to the .h file.
Thanks.
Ian