This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: Don't call put_data_offset twice
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Cc: espindola at google dot com
- Date: Fri, 4 Dec 2009 17:37:18 -0800
- Subject: PATCH: Don't call put_data_offset twice
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Hi,
put_data_offset twice is called earlier for different input files. It
shouldn't be called again. Otherwise, incremental dump on linker script
will fail. OK to install?
Thanks.
H.J.
----
2009-12-04 H.J. Lu <hongjiu.lu@intel.com>
* incremental.cc (Incremental_inputs::sized_create_inputs_section_data):
Don't call put_data_offset twice.
diff --git a/gold/incremental.cc b/gold/incremental.cc
index 506c575..e3107f1 100644
--- a/gold/incremental.cc
+++ b/gold/incremental.cc
@@ -674,7 +674,6 @@ Incremental_inputs::sized_create_inputs_section_data()
// TODO: add per input data and timestamp. Currently we store
// an out-of-bounds offset for future version of gold to reject
// such an incremental_inputs section.
- entry.put_data_offset(0xffffffff);
entry.put_timestamp_sec(it->second.mtime.seconds);
entry.put_timestamp_nsec(it->second.mtime.nanoseconds);
entry.put_input_type(it->second.type);