Re: Adding -Wshadow to binutils builds

[Tristan Gingold <gingold at adacore dot com>]

On Dec 11, 2009, at 10:06 AM, Nick Clifton wrote:

> Hi Guys,
> 
>  Last week I ran across a nasty bug in the MN10300 port due to one
>  local variable shadowing another.  As I was fixing it I realised
>  that the problem would have been found a lot earlier if we had
>  -Wshadow specified on the gcc command line when building the
>  binutils.  So I have spent the rest of the week adding this switch
>  and then fixing up all of the new warning messages that arise.  The
>  result is the attached patch (warning: large) which I plan to apply
>  later on today.
> 
>  I tested the patch with the following toolchains:  (If anybody knows
>  of any targets that I did not try, and which are not just simple
>  variants of the targets listed, then please let me know).

I suppose you didn't try hppa-hpux but AFAIK you can only build it on a native port.  Let me know
if you want me to test it.

Tristan.