This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gold][obvious patch] don't use std::vector::data


std::vector::data() is a relatively recent addition to GCC's STL
headers, apparently to resolve DR 464.

gcc version 4.0.3 (Ubuntu 4.0.3-1ubuntu5) didn't have it -- and I
tried to build gold with that version and the build failed.

Attached patch uses &front() instead.? (front() seems to have been in
STL Forever, and data() is implemented as &front().)


tested by building gold + running its tests with 4.0.3 and also 4.2.4
(Ubuntu 4.2.4-1ubuntu4).? (Note that build/test with 4.0.3 had a
couple of test failures which appear unrelated to this patch.)


checked in as obvious.


chris
---
[gold/ChangeLog]
2009-12-28? Chris Demetriou? <cgd@google.com>

??????? * attributes.cc (Output_attributes_section_data::do_write): Use
??????? std::vector::front rather than std::vector::data.

Attachment: gold_vector_data.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]