This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: PR gold/11144: dynamic_list.sh failed with gnu-hash
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Cc: Ian Lance Taylor <iant at google dot com>
- Date: Mon, 11 Jan 2010 06:59:38 -0800
- Subject: PATCH: PR gold/11144: dynamic_list.sh failed with gnu-hash
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Hi,
dynamic_list.stdout uses -Ds to dump dynamic symbol table. -Ds uses
symbol hash table in dynamic section. On Fedora/12, the gnu hash table
is the default, which ignores local and undefined symbols. dynamic_list.sh
failed with
Did not find expected text in dynamic_list.stdout:
_ZdlPv
since ZdlPv is undefined and doesn't appear in gnu-hash.
This patch uses the new --dyn-syms option to use dynamic symbol table.
OK for trunk?
Thanks.
H.J.
---
2010-01-11 H.J. Lu <hongjiu.lu@intel.com>
PR gold/11144
* testsuite/Makefile.am (dynamic_list.stdout): Use --dyn-syms
instead of -Ds.
* testsuite/Makefile.in: Regenerated.
diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am
index 2bf5bbe..2b40a85 100644
--- a/gold/testsuite/Makefile.am
+++ b/gold/testsuite/Makefile.am
@@ -1097,7 +1097,7 @@ dynamic_list: basic_test.o gcctestdir/ld $(srcdir)/dynamic_list.t
-Wl,--dynamic-list-cpp-new \
-Wl,--dynamic-list-cpp-typeinfo
dynamic_list.stdout: dynamic_list
- $(TEST_READELF) -DWs dynamic_list > dynamic_list.stdout
+ $(TEST_READELF) -W --dyn-syms dynamic_list > dynamic_list.stdout
check_PROGRAMS += thin_archive_test_1
MOSTLYCLEANFILES += libthin1.a libthin3.a libthinall.a \
diff --git a/gold/testsuite/Makefile.in b/gold/testsuite/Makefile.in
index 21fca3d..9f6f1de 100644
--- a/gold/testsuite/Makefile.in
+++ b/gold/testsuite/Makefile.in
@@ -2957,7 +2957,7 @@ uninstall-am:
@GCC_TRUE@@NATIVE_LINKER_TRUE@ -Wl,--dynamic-list-cpp-new \
@GCC_TRUE@@NATIVE_LINKER_TRUE@ -Wl,--dynamic-list-cpp-typeinfo
@GCC_TRUE@@NATIVE_LINKER_TRUE@dynamic_list.stdout: dynamic_list
-@GCC_TRUE@@NATIVE_LINKER_TRUE@ $(TEST_READELF) -DWs dynamic_list > dynamic_list.stdout
+@GCC_TRUE@@NATIVE_LINKER_TRUE@ $(TEST_READELF) -W --dyn-syms dynamic_list > dynamic_list.stdout
@GCC_TRUE@@NATIVE_LINKER_TRUE@libthin1.a: thin_archive_test_1.o alt/thin_archive_test_2.o
@GCC_TRUE@@NATIVE_LINKER_TRUE@ rm -f $@