This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: bug: GOLD handling of Sparc PLTREL
From: Ian Lance Taylor <iant@google.com>
Date: Tue, 09 Feb 2010 12:12:01 -0800
> David Miller <davem@davemloft.net> writes:
>
>> + if (this->od2)
>> + val += this->od2->data_size();
>
> Write this->od2 != NULL.
>
>> @@ -2045,7 +2051,13 @@ class Output_data_dynamic : public Output_section_data
>> offset_(section_size
>> ? DYNAMIC_SECTION_SIZE
>> : DYNAMIC_SECTION_ADDRESS)
>> - { this->u_.od = od; }
>> + { this->u_.od = od; this->od2 = NULL; }
>
> Use two separate lines.
>
>> + Dynamic_entry(elfcpp::DT tag, const Output_data* od, const Output_data* od2)
>> + : tag_(tag),
>> + offset_(DYNAMIC_SECTION_SIZE)
>> + { this->u_.od = od; this->od2 = od2; }
>
> Here too.
>
>
> This is OK with those changes.
Will do, thanks for reviewing Ian.