This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Include sysdep.h before stdio.h in ldlex.c

From: Richard Sandiford <rdsandiford at googlemail dot com>
To: Nick Clifton <nickc at redhat dot com>
Cc: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, binutils at sourceware dot org, Franz Fehringer <fehrin at t-online dot de>, Tristan Gingold <gingold at adacore dot com>
Date: Wed, 10 Feb 2010 19:54:23 +0000
Subject: Re: Include sysdep.h before stdio.h in ldlex.c
References: <878wb3v7nd.fsf@firetop.home> <20100209064019.GB6879@gmx.de> <87zl3ivzu8.fsf@firetop.home> <4B7274EA.1020504@redhat.com>

Nick Clifton <nickc@redhat.com> writes:
> Hi Richard,
>
>> Does this look OK to you?  Nick?
>
> I still think that you ought to have a comment in ldlex-wrapper.c 
> explaining why it is necessary,

Doh!  Sorry Nick, completely forgot to add that yesterday.
Here's what I used:

/* The flex output (ldlex.c) includes stdio.h before any of the C code
   in ldlex.l.  Make sure we include sysdep.h first, so that config.h
   can select the correct value of things like _FILE_OFFSET_BITS and
   _LARGE_FILES.  */

> but apart from that I have no other 
> objections and I am happy to approve it.

Applied, thanks.

Richard

References:
- Include sysdep.h before stdio.h in ldlex.c
  - From: Richard Sandiford
- Re: Include sysdep.h before stdio.h in ldlex.c
  - From: Ralf Wildenhues
- Re: Include sysdep.h before stdio.h in ldlex.c
  - From: Richard Sandiford
- Re: Include sysdep.h before stdio.h in ldlex.c
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]