This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] Objdump broken on 2.20 branch for ARM.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org, nickc at sourceware dot org, gingold at adacore dot com
- Date: Thu, 18 Feb 2010 15:07:54 +0000
- Subject: Re: [RFA] Objdump broken on 2.20 branch for ARM.
- References: <20100121120313.25441.qmail@sourceware.org> <1266503498.28369.10.camel@e102111-lin.cambridge.arm.com>
On Thu, 2010-02-18 at 14:31 +0000, Matthew Gretton-Dann wrote:
> Hi,
>
> I think this commit did not fix up the mis-applied patch correctly:
>
> > On Thu, 2010-01-21 at 12:03 +0000, nickc@sourceware.org wrote:
> > CVSROOT: /cvs/src
> > Module name: src
> > Branch: binutils-2_20-branch
> > Changes by: nickc@sourceware.org 2010-01-21 12:03:13
> >
> > Modified files:
> > opcodes : ChangeLog arm-dis.c
> >
> > Log message:
> > * arm-dis.c: Fix mis-applied patch.
> >
> > Patches:
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/opcodes/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.1438.2.20&r2=1.1438.2.21
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/opcodes/arm-dis.c.diff?cvsroot=src&only_with_tag=binutils-2_20-branch&r1=1.106.2.2&r2=1.106.2.3
>
> When running the gas testsuite I am getting 22 unexpected failures, all
> of which are aborts in objdump when disassembling 32-bit Thumb-2
> instructions, and which are not present before the patch was applied.
>
> The attached patch fixes the problem, by reinserting a break statement
> that the previous patch removed.
>
> Can someone review and approve this patch please? This only applies to
> the bintuils 2.20 branch.
>
Probably needs to be approved by Tristan as this is on the release
branch, but looks pretty obvious to me.
R.