This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: script-type test fails on ARM
- From: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- To: "Kirill A. Shutemov" <kirill at shutemov dot name>
- Cc: binutils <binutils at sourceware dot org>
- Date: Wed, 31 Mar 2010 14:29:24 +0100
- Subject: Re: script-type test fails on ARM
- References: <cc557aab1003221456k5e42d24bjb9232a75cb515027@mail.gmail.com>
Hi,
On Mon, 2010-03-22 at 23:56 +0200, Kirill A. Shutemov wrote:
> I've got problem with script-type test on ARM:
[snip]
> So, there is one extra line with $a comparing to script-type.sym.
> It's binutils-2.20.51-2010-03-22.
>
> Any ideas how to fix it?
Please find attached a patch that fixes this issue. There is nothing
wrong with the behaviour of the tools - rather the testsuite was
expecting incorrect output.
(The $d at 0x10 refers to the output of the .word directive in the
assembler, and the $a at 0x14 refers to the no-op intructions inserted
by the .p2align directive immediately after.
Suggested ChangeLog:
2010-03-31 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
* ld-arm/script-type.sym: Fix test.
Please can someone review and approve?
Thanks,
Matt
--
Matthew Gretton-Dann
Principal Engineer - Tools, PD Software
ARM Limited
Index: ld/testsuite/ld-arm/script-type.sym
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/script-type.sym,v
retrieving revision 1.1
diff -u -p -r1.1 script-type.sym
--- ld/testsuite/ld-arm/script-type.sym 23 Nov 2009 14:41:33 -0000 1.1
+++ ld/testsuite/ld-arm/script-type.sym 29 Mar 2010 16:30:22 -0000
@@ -1,15 +1,16 @@
-Symbol table '.symtab' contains 12 entries:
+Symbol table '.symtab' contains 13 entries:
Num: Value Size Type Bind Vis Ndx Name
0: 00000000 0 NOTYPE LOCAL DEFAULT UND
1: 00000000 0 SECTION LOCAL DEFAULT 1
2: 00000000 0 SECTION LOCAL DEFAULT 2
3: 00000000 0 NOTYPE LOCAL DEFAULT 1 \$a
4: 00000010 0 NOTYPE LOCAL DEFAULT 1 \$d
- 5: 00000020 0 NOTYPE LOCAL DEFAULT 1 \$t
- 6: 00000010 0 OBJECT GLOBAL DEFAULT 1 bar_o
- 7: 00000021 0 FUNC GLOBAL DEFAULT 1 bar_t
- 8: 00000000 0 FUNC GLOBAL DEFAULT 1 foo_a
- 9: 00000021 0 FUNC GLOBAL DEFAULT 1 foo_t
- 10: 00000010 0 OBJECT GLOBAL DEFAULT 1 foo_o
- 11: 00000000 0 FUNC GLOBAL DEFAULT 1 bar_a
+ 5: 00000014 0 NOTYPE LOCAL DEFAULT 1 \$a
+ 6: 00000020 0 NOTYPE LOCAL DEFAULT 1 \$t
+ 7: 00000010 0 OBJECT GLOBAL DEFAULT 1 bar_o
+ 8: 00000021 0 FUNC GLOBAL DEFAULT 1 bar_t
+ 9: 00000000 0 FUNC GLOBAL DEFAULT 1 foo_a
+ 10: 00000021 0 FUNC GLOBAL DEFAULT 1 foo_t
+ 11: 00000010 0 OBJECT GLOBAL DEFAULT 1 foo_o
+ 12: 00000000 0 FUNC GLOBAL DEFAULT 1 bar_a