This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold][patch] Cleanup more mmap leakage

From: Ian Lance Taylor <iant at google dot com>
To: Cary Coutant <ccoutant at google dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Wed, 07 Apr 2010 15:47:44 -0700
Subject: Re: [gold][patch] Cleanup more mmap leakage
References: <c17be2b31003261613r5ebcd8dck8b1134ed64f2160a@mail.gmail.com>

Cary Coutant <ccoutant@google.com> writes:

>         * archive.cc (include_member): Destroy Read_symbols_data object before
>         releasing file.
>         * object.cc (Read_symbols_data::~Read_symbols_data) New destructor.
>         * object.h (Read_symbols_data::Read_symbols_data) New constructor.
>         (Read_symbols_data::~Read_symbols_data) New destructor.
>         (Section_relocs::Section_relocs) New constructor.
>         (Section_relocs::~Section_relocs) New destructor.
>         (Read_relocs_data::Read_relocs_data) New constructor.
>         (Read_relocs_data::~Read_relocs_data) New destructor.
>         * testsuite/binary_unittest.cc (Sized_binary_test): Set sd member
>         pointers to NULL after deleting.

This is OK.

Thanks.

Ian

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]